International Federation of Digital Seismograph Networks

Thread: Proposal for changes to unify response elements

None
Started: 2015-07-14 19:48:34
Last activity: 2015-07-14 19:48:34
Philip Crotwell
2015-07-14 19:48:34
Hi

I have another proposal to update FDSN StationXML and wanted to toss it
out.

1) Change NumeratorCoefficient in FIRType to use attribute "number" instead
of "i" and add attribute "number" to Numerator and Demoninator in
CoefficientsType.

Currently
PoleZero in PolesZerosType are numbered with "number",
NumeratorCoeffiecient is numbered in FIRType with "i",
Numerator and Demoninator are not numbered in CoefficientsType,
Coefficient is numbered with "number" in PolynomialType

It would be nice if these were all uniform. Probably all coefficients
should be numbered or none, and would be nice if the names were the same,
using "number" instead of "i". Mathematically, the poles and zeros don't
really need to be numbered as they are just multiplication and commute, but
order matters for coefficients. Could consider removing "number" from
PoleZeroType.

2) Change NumeratorCoefficient in FIRType and Numerator and Demoninator
in CoefficientsType to FloatNoUnitType.

Currently
PoleZeroType is FloatNoUnitType
FIRType NumeratorCoefficient is xs:double,
CoefficientsType Numerator and Demoninator are FloatType,
PolynomialType Coefficient is FloatNoUnitType

and it would be good if all of these were treated the same.

The attribute change (1) would cause a change in code, but in many cases I
think the FloatNoUnitType (2) would probably not require any code changes
on existing clients or servers.

A github pull request is here:

https://github.com/FDSN/StationXML/pull/1

thanks,
Philip

  • Stephane Zuzlewski
    2015-07-14 17:47:43
    Hi Philip,

    Your proposal makes sense; having some consistency would be desirable.
    The least invasive change is probably to assign NumeratorCoefficient with
    "number" instead of "i" and to number Numerator & Denominator as well.


    Stephane


    On 7/14/15 9:48 AM, Philip Crotwell wrote:

    Hi

    I have another proposal to update FDSN StationXML and wanted to toss
    it out.

    1) Change NumeratorCoefficient in FIRType to use attribute "number"
    instead of "i" and add attribute "number" to Numerator and Demoninator
    in CoefficientsType.

    Currently
    PoleZero in PolesZerosType are numbered with "number",
    NumeratorCoeffiecient is numbered in FIRType with "i",
    Numerator and Demoninator are not numbered in CoefficientsType,
    Coefficient is numbered with "number" in PolynomialType

    It would be nice if these were all uniform. Probably all coefficients
    should be numbered or none, and would be nice if the names were the
    same, using "number" instead of "i". Mathematically, the poles and
    zeros don't really need to be numbered as they are just multiplication
    and commute, but order matters for coefficients. Could consider
    removing "number" from PoleZeroType.

    2) Change NumeratorCoefficient in FIRType and Numerator and
    Demoninator in CoefficientsType to FloatNoUnitType.

    Currently
    PoleZeroType is FloatNoUnitType
    FIRType NumeratorCoefficient is xs:double,
    CoefficientsType Numerator and Demoninator are FloatType,
    PolynomialType Coefficient is FloatNoUnitType

    and it would be good if all of these were treated the same.

    The attribute change (1) would cause a change in code, but in many
    cases I think the FloatNoUnitType (2) would probably not require any
    code changes on existing clients or servers.

    A github pull request is here:

    https://github.com/FDSN/StationXML/pull/1

    thanks,
    Philip


    _______________________________________________
    fdsn-wg2-data mailing list
    fdsn-wg2-data<at>iris.washington.edu
    http://www.iris.washington.edu/mailman/listinfo/fdsn-wg2-data

    --
    ------------------------------------------------------------------
    Stephane Zuzlewski University of California, Berkeley
    stephane<at>seismo.berkeley.edu Berkeley Seismological Laboratory
    Office: 510-664-9029 (Thu) 215 McCone Hall # 4760
    Fax: 510-643-5811 Berkeley, CA 94720-4760
    Remote: 209-724-9540 (Mon,Tue,Wed,Fri)